Repository navigation
ci: define the labels as code and triage pull requests by them - #1426
Merged
Merged
Conversation
Every label is defined in .github/labels.yml, grouped into families named for the question each answers: area, status, size, priority, type and ci. scripts/sync-labels.py applies the file, renaming labels in place so everything that carries one keeps it; a pull request that changes it gets a dry run, and the push to main applies it. pr-triage.yml sizes every pull request from its reviewable lines and gives a ready one with no status 'status: waiting on review'. label-gate.yml fails while a pull request carries a status that holds the merge. Every workflow, template and doc that named a label now uses the new name. docs/labels.md describes the system.
Contributor
Bundle size reportCompared with
WebAssembly modules
No file changed size. Commit: 7294af9 |
Contributor
|
CI Status: 24 required jobs green, 22 passed and 2 skipped by path filter. All job results
Signing credentials: valid as of 2026-10-29 Commit |
|
16.10 Decisions: Issue fields: Labels at the Issue level:
There are other non-grouped labels on the issue level. Labels at the PR level:
|
# Conflicts: # .github/workflows/host-playground-e2e.yml # .github/workflows/ios-pr.yml # README.md
Names are family:value, matching the labels created in the repository. Issues take area, needs and spa; pull requests take status, needs, size and ci. Type, status and target date on issues are issue fields, so the type and priority families are gone, and the labels whose replacement is still open are held as pending. Pull requests no longer carry an area. issue-areas.yml adds the areas a pull request touches to the issues it closes, reading the path map from .github/areas.yml, which check-path-routing.py now holds to CODEOWNERS. The backport job finds its open work order by branch rather than by area label. The label gate holds on any needs label and on status:blocked.
TarikGul
marked this pull request as ready for review
October 20, 2026 13:10
When a new label and an old one both exist, the sync merges the one on fewer items into the other and gives the survivor the new name, so the migration writes 21 labels rather than one per pull request carrying an old one. Writes pause between calls and back off on rate limits, and a merge skips items already labelled, so an interrupted run can be repeated. issue-areas.yml runs when a pull request merges, so an unmerged or forked pull request cannot label issues. pr-triage.yml reads .gitattributes with the permission it needs and matches its patterns as git does. The RFC skill's commands use area:rfc, and the docs say when areas are applied, that older pull requests keep theirs, and that priority is an issue field.
# Conflicts: # .github/workflows/ios-device-preview.yml # .github/workflows/ios-pr.yml
Agents label pull requests and file issues, so the skill says which labels to set by hand and which are automatic, when a ci: label is worth its macOS jobs, how status and needs labels move, and that a label is only ever added or renamed through .github/labels.yml.
|
@TarikGul fyi I've deprecated |
# Conflicts: # .github/workflows/android-instrumented-tests.yml # .github/workflows/ci.yml
eugypalu
reviewed
Oct 26, 2026
eugypalu
reviewed
Oct 26, 2026
decrypto21
reviewed
Oct 26, 2026
# Conflicts: # .github/workflows/android-device-preview.yml # .github/workflows/android-instrumented-tests.yml # .github/workflows/ci.yml # .github/workflows/host-playground-e2e.yml # .github/workflows/ios-app.yml # .github/workflows/ios-device-preview.yml # README.md
issue-areas.yml reads .github/areas.yml from the merge commit, so a pull request opened before the file existed still finds it. The sync plan job reads pull requests, so its counts match the apply. areas.yml takes a ! glob to keep docs/rfcs/ out of area:docs, and check-path-routing.py fails on an area labels.yml does not define. python and Stability are pending.
eugypalu
approved these changes
Oct 27, 2026
decrypto21
approved these changes
Oct 27, 2026
decrypto21
left a comment
Contributor
There was a problem hiding this comment.
Approved, nits:
pr-triage.yml:25:cancel-in-progresscan drop the status when a push follows open, ready or draft. Set it on every event.label-gate.yml:16: merge_group always passes, but queued pull requests can still be labelled.issue-areas.yml:70: 404 when the base has noareas.yml(release/*).- Old label names left in comments in the iOS, Android and e2e preview workflows.
…ued runs pr-triage.yml decides status:waiting-on-review from the pull request's state on every event, so a run a push cancels leaves nothing the next run misses. Label gate reads the queued pull request's labels in the merge queue, since a queued pull request can still be labelled. issue-areas.yml labels nothing when the base branch has no areas.yml, and the preview workflows' comments name the ci: labels.
The local builds guide names the ci: labels.
needs: and status: labels organise pull requests and say who acts next. Only ci: labels affect CI, so no check fails on a needs: label or status:blocked.
TarikGul
enabled auto-merge
October 29, 2026 22:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines every label in
.github/labels.ymland triages pull requests and issues by them, following up on the process workshop and the label decisions of 16.10.docs/labels.mddescribes the system.Names are
family:value, matching the labels already created in the repository.On issues
area:(core, ios, android, js, ci, docs, rfc)needs:(decision, spec, UI)spa:(humanity, jollity, scarcity, seity)Type, status, priority and target date on issues are issue fields, not labels.
On pull requests
status:(waiting-on-review, waiting-on-author, ready-to-merge, blocked)waiting-on-reviewautomatically, the rest by handneeds:(decision, spec, UI)size:(XS to XXL)ci:(ios-simulator, ios-device, android-device, android-emulator-tests, host-playground-e2e, no-changeset)scripts/sync-labels.pyapplies the file. It renames labels in place so everything keeps what it carries. Where the new name already exists, it merges whichever label is on fewer items into the other and gives the survivor the new name, so the migration writes 21 labels rather than one per item. Writes are paced and retried on rate limits, and an interrupted run can be repeated. This pull request's checks include a dry run of the 23 changes: the old path labels becomearea:labels (rustabsorbs the 21 issues already onarea:core), each old build label becomes itsci:label in the same merge that switches the workflows over, andinvalid,w3sandpost-w3sare deleted. Nothing changes until it merges.issue-areas.ymlruns when a pull request merges and adds the areas it touched to the issues it closes, from the paths in.github/areas.yml, whichcheck-path-routing.pyholds to CODEOWNERS. Older pull requests keep the areas they had.pr-triage.ymlsizes every pull request from the lines a reviewer reads, leaving out what.gitattributesmarks generated, lockfiles and database schemas, and gives a ready pull request with no statusstatus:waiting-on-review. The backport job finds its work order by branch.Beyond the 16.10 decisions:
needs:labels also go on pull requests. They organise pull requests and never affect CI, since onlyci:labels do.Left as they are until decided:
Epic,enhancement,feature request,proposal,R2 blocker,R3+andhost-work.After merge:
rfc, which becomesarea:rfc#1396 names the build labels by their old names, so whichever of the two merges second needs a small update.